Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't close Neovim if there's only packer's window #902

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't close Neovim if there's only packer's window #902

wants to merge 1 commit into from

Conversation

mawkler
Copy link
Contributor

@mawkler mawkler commented May 3, 2022

display.close previously closed Neovim if there were no other windows

@wbthomason
Copy link
Owner

Thanks, and sorry for taking so long to get to this! Do you have an easy reproduction example? I haven't encountered this behavior before.

Separately, though I think it's probably wise to move to api.nvim_win_close regardless, I would feel more comfortable if we stored and used the display window ID rather than relying on the display window being the current window (i.e. by passing 0)

@mawkler
Copy link
Contributor Author

mawkler commented Jul 26, 2022

Do you have an easy reproduction example?

  1. Open a Packer window for instance using :PackerStatus
  2. Close all other windows using <C-w><C-o>
  3. Close Packer window by pressing q

@mawkler
Copy link
Contributor Author

mawkler commented Jul 26, 2022

I would feel more comfortable if we stored and used the display window ID

I'm not sure exactly how you want this to be implemented, but feel free to add a commit that fixes this and/or elaborate :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mawkler @wbthomason