Feat: Add support for PKCS12 / PFX client certificates for mTLS #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietrygamat
force-pushed
the
feature/client-certificate-p12
branch
from
6312a86
to
07d3089
Compare
|
Thank you @pietrygamat ! @lohxt1 Lets target this to have it merged for next weeks release. |
pietrygamat
force-pushed
the
feature/client-certificate-p12
branch
from
07d3089
to
bf4eb21
Compare
lohxt1
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change allows bruno to use client certificates stored in PFX / PKCS12 files in addition to regular PEM cert/key pairs.
Updated the Client Certificate selection in Collection view so that the user can specify if they are using pfx format, in which case the key file becomes unnecessary, and the control disabled. The passphrase field works for both formats.
Axios used by bruno has the support built-in so this change is a rather trivial one, with only the question of UI to solve.
resolves #1889
resolves #1698
Contribution Checklist:
For reference: Postman implementation
