-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(css/parser): comments supporting #5504
base: main
Are you sure you want to change the base?
feat(css/parser): comments supporting #5504
Conversation
a { | ||
background: /* Leading */ red /* Trailing */; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Can you add some comments in the function and in the at rule?
e.g.
@media (width >/* foo */= 30em) {
.test {
width: calc(100%-/* foo */20px);
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yisibl Yes, I am still thinkig how better solve it, here just example how we should store them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you resolve this issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, planned, want to finish some stuff before it
Any ETA on getting this merged? |
Description:
Partial #5384
BREAKING CHANGE:
Yes
Related issue (if exists):
No