Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install lua from the os package repository #5655

Merged
merged 1 commit into from
May 28, 2024
Merged

Install lua from the os package repository #5655

merged 1 commit into from
May 28, 2024

Conversation

ferrarimarco
Copy link
Collaborator

Proposed changes

  • Install lua and luarocks from the OS package repository instead of manually downloading them. Also the luarock fork looked unmaintained.
  • Remove luarocks from the image after installing lua packages because it's not needed after that

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER label to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@ferrarimarco ferrarimarco added infrastructure related to project structure and maintenance O: backlog 🤖 Backlog, stale ignores this label labels May 16, 2024
@ferrarimarco ferrarimarco self-assigned this May 16, 2024
@ferrarimarco ferrarimarco modified the milestones: 6.5.1, 6.6.0 May 16, 2024
- Install lua and luarocks from the OS package repository instead of
  manually downloading them. Also the luarock fork looked
  unmaintained.
- Remove luarocks from the image after installing lua packages because
  it's not needed after that
@ferrarimarco ferrarimarco merged commit 6af32f6 into main May 28, 2024
106 checks passed
@ferrarimarco ferrarimarco deleted the fix-luarocks branch May 28, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure related to project structure and maintenance O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant