Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-utils): add tsBuildInfoFile to fix incremental options #20341

Merged
merged 1 commit into from
May 20, 2024

Conversation

innerdvations
Copy link
Contributor

@innerdvations innerdvations commented May 20, 2024

What does it do?

Adds a tsBuildInfoFile to tsconfig so that incremental option works

Why is it needed?

v5 plugins are receiving build errors in v5 because of this missing config value (among other things that are solved in strapi/sdk-plugin)

How to test it?

using this updated config should allow to build without receiving the error [ERROR] Option '--incremental' can only be specified using tsconfig, emitting to single file or when option '--tsBuildInfoFile' is specified.

Related issue(s)/PR(s)

DX-1400

@innerdvations innerdvations added pr: fix This PR is fixing a bug source: typescript Source is related to TypeScript (typings, tooling, ...) labels May 20, 2024
@innerdvations innerdvations changed the title fix(typescript-utils): fix incremental with tsBuildInfoFile fix(typescript-utils): add tsBuildInfoFile to fix incremental options May 20, 2024
@innerdvations innerdvations requested a review from Convly May 20, 2024 15:14
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@innerdvations innerdvations merged commit 7f81f32 into v5/main May 20, 2024
80 of 85 checks passed
@innerdvations innerdvations deleted the fix/ts-utils-build-info branch May 20, 2024 15:26
@echoes-hq echoes-hq bot added the echoes/type: bug Effort to correct undesirable or incorrect behavior label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/type: bug Effort to correct undesirable or incorrect behavior pr: fix This PR is fixing a bug source: typescript Source is related to TypeScript (typings, tooling, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants