Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: overlapping send details #20102

Merged
merged 4 commits into from
May 21, 2024
Merged

fix: overlapping send details #20102

merged 4 commits into from
May 21, 2024
+6 −10

Conversation

OmarBasem
Copy link
Member

@OmarBasem OmarBasem commented May 20, 2024 •
edited

fixes: #20039

Summary

This PR fixes the overlapping details on the transaction confirmation screen

Skipping QA as it is a minor ui detail.

Demo

IMG_5233.MP4

@OmarBasem OmarBasem self-assigned this May 20, 2024
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA May 20, 2024
@status-im-auto
Copy link
Member

status-im-auto commented May 20, 2024 •
edited

Jenkins Builds

Click to see older builds (11)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 8731346 #1 2024-05-20 08:50:12 ~2 min tests 📄log
✔️ 8731346 #1 2024-05-20 08:55:19 ~7 min android-e2e 🤖apk 📲
✔️ 8731346 #1 2024-05-20 08:55:20 ~7 min android 🤖apk 📲
✔️ 8731346 #1 2024-05-20 08:57:35 ~9 min ios 📱ipa 📲
❌ 96793a6 #2 2024-05-20 09:04:55 ~2 min tests 📄log
✔️ 96793a6 #2 2024-05-20 09:07:39 ~5 min android-e2e 🤖apk 📲
✔️ 96793a6 #2 2024-05-20 09:07:57 ~6 min android 🤖apk 📲
✔️ 96793a6 #2 2024-05-20 09:10:43 ~8 min ios 📱ipa 📲
❌ 0494404 #4 2024-05-20 09:34:58 ~3 min tests 📄log
✔️ 0494404 #4 2024-05-20 09:38:28 ~6 min android 🤖apk 📲
✔️ 0494404 #4 2024-05-20 09:40:58 ~9 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 2ffed6b #5 2024-05-21 05:18:35 ~2 min tests 📄log
✔️ 2ffed6b #5 2024-05-21 05:22:24 ~5 min android-e2e 🤖apk 📲
✔️ 2ffed6b #5 2024-05-21 05:22:54 ~6 min android 🤖apk 📲
✔️ 2ffed6b #5 2024-05-21 05:25:01 ~8 min ios 📱ipa 📲
✔️ 4f19405 #6 2024-05-21 06:55:51 ~5 min tests 📄log
✔️ 4f19405 #6 2024-05-21 06:56:37 ~6 min android-e2e 🤖apk 📲
✔️ 4f19405 #6 2024-05-21 06:59:05 ~8 min android 🤖apk 📲
✔️ 4f19405 #6 2024-05-21 07:00:57 ~10 min ios 📱ipa 📲

@OmarBasem OmarBasem force-pushed the fix/send-details-overlapping branch from 45ee61c to 0494404 Compare May 20, 2024 09:31
@OmarBasem OmarBasem moved this from REVIEW to E2E Tests in Pipeline for QA May 20, 2024
@status-im-auto
Copy link
Member

88% of end-end tests have passed

Total executed tests: 52
Failed tests: 4
Expected to fail tests: 2
Passed tests: 46

IDs of failed tests: 727230,727229,702807,727232 

IDs of expected to fail tests: 703503,703495

Failed tests (4)

Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Find `Text` by `xpath`: `//*[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView`
    Device 2: `Text` is `Sent` 

    critical/chats/test_group_chat.py:95: in test_group_chat_join_send_text_messages_push
    self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120)
../views/chat_view.py:225: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent



    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_watch_only_account, id: 727232

    Device 1: Text is eth:oeth:arb1:0x8d2413447ff297d30bdc475f6d5cb00254685aae
    Device 1: Click system back button 

    critical/test_wallet.py:212: in test_wallet_add_remove_watch_only_account
    self.home_view.driver.fail(
base_test_case.py:178: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Incorrect address 'eth:oeth:arb1:0x8d2413447ff297d30bdc475f6d5cb00254685aae' is shown when swiping between accounts, expected one is '0:x:8:d:2:4:1:3:4:4:7:f:f:2:9:7:d:3:0:b:d:c:4:7:5:f:6:d:5:c:b:0:0:2:5:4:6:8:5:a:a:e'



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    # STEP: Getting ETH amount in the wallet of the sender before transaction
    Device 1: Find WalletTab by accessibility id: wallet-stack-tab 

    critical/test_wallet.py:119: in test_wallet_send_asset_from_drawer
    sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx()
critical/test_wallet.py:41: in _get_balances_before_tx
    self.wallet_1.wallet_tab.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: WalletTab by accessibility id: `wallet-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    2. test_wallet_send_eth, id: 727229

    Device 1: Swiping right on element SlideButton
    Device 1: Find SlideButton by xpath: //*[@resource-id='slide-button-track'] 

    critical/test_wallet.py:111: in test_wallet_send_eth
    self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send)
../views/wallet_view.py:100: in send_asset
    self.confirm_transaction()
../views/wallet_view.py:87: in confirm_transaction
    self.slide_and_confirm_with_password()
../views/wallet_view.py:81: in slide_and_confirm_with_password
    self.slide_button_track.slide()
../views/base_view.py:257: in slide
    self.swipe_right_on_element(width_percentage=1.3, start_x=100)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: SlideButton by xpath: `//*[@resource-id='slide-button-track']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Expected to fail tests (2)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement 

    critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

    [[Chat is not unmuted after expected time: https://github.com//issues/19627]]

    Device sessions

    Passed tests (46)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    2. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    2. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    3. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    4. test_1_1_chat_edit_message, id: 702855
    Device sessions

    5. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    6. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    7. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    8. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_offline_pn, id: 702808
    Device sessions

    2. test_group_chat_pin_messages, id: 702732
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    4. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    5. test_community_leave, id: 702845
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_mute_community_and_channel, id: 703382
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    4. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    5. test_community_undo_delete_message, id: 702869
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    3. test_community_message_delete, id: 702839
    Device sessions

    4. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    5. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    6. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    9. test_community_one_image_send_reply, id: 702859
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    11. test_community_message_edit, id: 702843
    Device sessions

    @mariia-skrypnyk
    Copy link

    Hi @OmarBasem !

    Thanks for your fix!
    Anyway, do not hesitate to put reason/s why your PR skips manual qa.
    The whole Pipline process with all details you can find here 👉 https://github.com/status-im/status-mobile/blob/develop/doc/pipeline_process.md

    Failed e2e tests are not related.

    @mariia-skrypnyk mariia-skrypnyk moved this from E2E Tests to MERGE in Pipeline for QA May 20, 2024
    @OmarBasem OmarBasem force-pushed the fix/send-details-overlapping branch from 0494404 to 2ffed6b Compare May 21, 2024 05:16
    @OmarBasem OmarBasem merged commit 34cf65b into develop May 21, 2024
    6 checks passed
    Pipeline for QA automation moved this from MERGE to DONE May 21, 2024
    @OmarBasem OmarBasem deleted the fix/send-details-overlapping branch May 21, 2024 07:19
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @J-Son89 J-Son89 J-Son89 approved these changes

    @BalogunofAfrica BalogunofAfrica BalogunofAfrica approved these changes

    @vkjr vkjr Awaiting requested review from vkjr

    @mmilad75 mmilad75 Awaiting requested review from mmilad75

    Assignees

    @OmarBasem OmarBasem

    Labels
    skip-manual-qa
    Projects
    Pipeline for QA
      
    DONE
    Pipeline for QA
    Status: DONE
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Details overlapping on Wallet Send screen
    5 participants
    @OmarBasem @status-im-auto @mariia-skrypnyk @J-Son89 @BalogunofAfrica