Switch to Poetry, adopt tox and pytest #2127
Open
+481
−761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matheus Felipe <matheusfelipeog@gmail.com>
Co-authored-by: Matheus Felipe <matheusfelipeog@gmail.com>
This reverts commit 606743b.
Co-authored-by: Matheus Felipe <matheusfelipeog@gmail.com>
ppfeister
added
enhancement
Co-authored-by: Siddharth Dushantha <siddharth.dushantha@gmail.com>
When using tox, pass `-e offline` to exclude online tests. When using pytest, pass `-m "not online"` to do the same.
|
Rebased to #2111 feature/pyproj to fix conflicts |
Workflow found to be ineffective after the removal of unclaimed_usernames. All sites skipped by tests due to the lack of this value, leading to false success of this test. Workflow will be eventually rewritten following the new standard.
Workflow made redundant with the addition of Regression workflow, which runs on both push to and PR against master.
sdushantha
requested changes
Jun 1, 2024
Co-authored-by: Siddharth Dushantha <siddharth.dushantha@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #2111Partially consolidated. (Poetry review notes in original blocker, #2111)toxnow suitable (and recommended) for running unit tests across several environments at once with linting and coverage reporting.Will be adopted by GitHub Actions later to remedy lost functionality from Poetry adoption.