Register creak_node_hook #126671
Closed
Register creak_node_hook #126671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shengfukevin
requested review from
avikchaudhuri,
gmagogsfm,
tugsbayasgalan and
zhxchen17
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126671
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit e7327b1 with merge base 9117779 ( UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D57469157 |
shengfukevin
force-pushed
the
export-D57469157
branch
from
83861f7
to
85acbbc
Compare
shengfukevin
added a commit
to shengfukevin/pytorch
that referenced
this pull request
May 20, 2024
Summary: Pull Request resolved: pytorch#126671 Differential Revision: D57469157
|
This pull request was exported from Phabricator. Differential Revision: D57469157 |
shengfukevin
force-pushed
the
export-D57469157
branch
from
85acbbc
to
d16b8c8
Compare
shengfukevin
added a commit
to shengfukevin/pytorch
that referenced
this pull request
May 20, 2024
Summary: Pull Request resolved: pytorch#126671 Differential Revision: D57469157
|
This pull request was exported from Phabricator. Differential Revision: D57469157 |
shengfukevin
force-pushed
the
export-D57469157
branch
from
d16b8c8
to
db89d50
Compare
shengfukevin
added a commit
to shengfukevin/pytorch
that referenced
this pull request
May 20, 2024
) Summary: GraphModule supports a call back function (_create_node_hook) for creating a node, it is mainly for meta data export. In my prototype(https://www.internalfb.com/diff/D56974659), I also use the call back functions for creating/erasing a node to observe the change in every pass of graph transform. So it means GraphModule may have multiple observers listening to the change of the graph. This DIFF is to support multiple hooks for both creating and erasing nodes. I am going to have a few follow up DIFFs to support GraphTransformObserver after this DIFF is landed. Test Plan: buck2 test mode/dev-nosan //caffe2/test:test_export Differential Revision: D57469157
|
This pull request was exported from Phabricator. Differential Revision: D57469157 |
shengfukevin
force-pushed
the
export-D57469157
branch
from
db89d50
to
4f4d389
Compare
shengfukevin
added a commit
to shengfukevin/pytorch
that referenced
this pull request
May 20, 2024
…#126671) Summary: GraphModule supports a call back function (_create_node_hook) for creating a node, it is mainly for meta data export. In my prototype(https://www.internalfb.com/diff/D56974659), I also use the call back functions for creating/erasing a node to observe the change in every pass of graph transform. So it means GraphModule may have multiple observers listening to the change of the graph. This DIFF is to support multiple hooks for both creating and erasing nodes. I am going to have a few follow up DIFFs to support GraphTransformObserver after this DIFF is landed. Test Plan: buck2 test mode/dev-nosan //caffe2/test:test_export Differential Revision: D57469157
|
This pull request was exported from Phabricator. Differential Revision: D57469157 |
shengfukevin
force-pushed
the
export-D57469157
branch
from
4f4d389
to
1ddb127
Compare
pytorch-bot bot
pushed a commit
that referenced
this pull request
May 22, 2024
Summary: GraphModule supports a call back function (_create_node_hook) for creating a node, it is mainly for meta data export. In my prototype(https://www.internalfb.com/diff/D56974659), I also use the call back functions for creating/erasing a node to observe the change in every pass of graph transform. So it means GraphModule may have multiple observers listening to the change of the graph. This DIFF is to support multiple hooks for both creating and erasing nodes. I am going to have a few follow up DIFFs to support GraphTransformObserver after this DIFF is landed. Test Plan: buck2 test mode/dev-nosan //caffe2/test:test_export buck2 test mode/dev-sand caffe2/test:fx -- fx.test_fx_node_hook.TestFXNodeHook Differential Revision: D57469157
|
This pull request was exported from Phabricator. Differential Revision: D57469157 |
shengfukevin
force-pushed
the
export-D57469157
branch
from
1ddb127
to
d2dfbb5
Compare
shengfukevin
added a commit
to shengfukevin/pytorch
that referenced
this pull request
May 22, 2024
…#126671) Summary: GraphModule supports a call back function (_create_node_hook) for creating a node, it is mainly for meta data export. In my prototype(https://www.internalfb.com/diff/D56974659), I also use the call back functions for creating/erasing a node to observe the change in every pass of graph transform. So it means GraphModule may have multiple observers listening to the change of the graph. This DIFF is to support multiple hooks for both creating and erasing nodes. I am going to have a few follow up DIFFs to support GraphTransformObserver after this DIFF is landed. Test Plan: buck2 test mode/dev-nosan //caffe2/test:test_export buck2 test mode/dev-sand caffe2/test:fx -- fx.test_fx_node_hook.TestFXNodeHook Differential Revision: D57469157
|
This pull request was exported from Phabricator. Differential Revision: D57469157 |
shengfukevin
force-pushed
the
export-D57469157
branch
from
d2dfbb5
to
2fb4de5
Compare
shengfukevin
added a commit
to shengfukevin/pytorch
that referenced
this pull request
May 22, 2024
…#126671) Summary: GraphModule supports a call back function (_create_node_hook) for creating a node, it is mainly for meta data export. In my prototype(https://www.internalfb.com/diff/D56974659), I also use the call back functions for creating/erasing a node to observe the change in every pass of graph transform. So it means GraphModule may have multiple observers listening to the change of the graph. This DIFF is to support multiple hooks for both creating and erasing nodes. I am going to have a few follow up DIFFs to support GraphTransformObserver after this DIFF is landed. Test Plan: buck2 test mode/dev-nosan //caffe2/test:test_export buck2 test mode/dev-sand caffe2/test:fx -- fx.test_fx_node_hook.TestFXNodeHook Differential Revision: D57469157
|
This pull request was exported from Phabricator. Differential Revision: D57469157 |
|
@pytorchbot merge |
Merge failedReason: This PR has internal changes and must be landed via Phabricator Details for Dev Infra teamRaised by workflow job |
shengfukevin
force-pushed
the
export-D57469157
branch
from
2fb4de5
to
d2f3a54
Compare
pytorch-bot bot
pushed a commit
that referenced
this pull request
May 24, 2024
Summary: GraphModule supports a call back function (_create_node_hook) for creating a node, it is mainly for meta data export. In my prototype(https://www.internalfb.com/diff/D56974659), I also use the call back functions for creating/erasing a node to observe the change in every pass of graph transform. So it means GraphModule may have multiple observers listening to the change of the graph. This DIFF is to support multiple hooks for both creating and erasing nodes. I am going to have a few follow up DIFFs to support GraphTransformObserver after this DIFF is landed. Test Plan: buck2 test mode/dev-nosan //caffe2/test:test_export buck2 test mode/dev-sand caffe2/test:fx -- fx.test_fx_node_hook.TestFXNodeHook Reviewed By: angelayi Differential Revision: D57469157
|
This pull request was exported from Phabricator. Differential Revision: D57469157 |
shengfukevin
added a commit
to shengfukevin/pytorch
that referenced
this pull request
May 24, 2024
…#126671) Summary: GraphModule supports a call back function (_create_node_hook) for creating a node, it is mainly for meta data export. In my prototype(https://www.internalfb.com/diff/D56974659), I also use the call back functions for creating/erasing a node to observe the change in every pass of graph transform. So it means GraphModule may have multiple observers listening to the change of the graph. This DIFF is to support multiple hooks for both creating and erasing nodes. I am going to have a few follow up DIFFs to support GraphTransformObserver after this DIFF is landed. Test Plan: buck2 test mode/dev-nosan //caffe2/test:test_export buck2 test mode/dev-sand caffe2/test:fx -- fx.test_fx_node_hook.TestFXNodeHook Reviewed By: angelayi Differential Revision: D57469157
shengfukevin
force-pushed
the
export-D57469157
branch
from
d2f3a54
to
525a0be
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57469157 |
shengfukevin
added a commit
to shengfukevin/pytorch
that referenced
this pull request
May 24, 2024
…#126671) Summary: GraphModule supports a call back function (_create_node_hook) for creating a node, it is mainly for meta data export. In my prototype(https://www.internalfb.com/diff/D56974659), I also use the call back functions for creating/erasing a node to observe the change in every pass of graph transform. So it means GraphModule may have multiple observers listening to the change of the graph. This DIFF is to support multiple hooks for both creating and erasing nodes. I am going to have a few follow up DIFFs to support GraphTransformObserver after this DIFF is landed. Test Plan: buck2 test mode/dev-nosan //caffe2/test:test_export buck2 test mode/dev-sand caffe2/test:fx -- fx.test_fx_node_hook.TestFXNodeHook Reviewed By: angelayi Differential Revision: D57469157
shengfukevin
force-pushed
the
export-D57469157
branch
from
525a0be
to
63855de
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57469157 |
…#126671) Summary: GraphModule supports a call back function (_create_node_hook) for creating a node, it is mainly for meta data export. In my prototype(https://www.internalfb.com/diff/D56974659), I also use the call back functions for creating/erasing a node to observe the change in every pass of graph transform. So it means GraphModule may have multiple observers listening to the change of the graph. This DIFF is to support multiple hooks for both creating and erasing nodes. I am going to have a few follow up DIFFs to support GraphTransformObserver after this DIFF is landed. Test Plan: buck2 test mode/dev-nosan //caffe2/test:test_export buck2 test mode/dev-sand caffe2/test:fx -- fx.test_fx_node_hook.TestFXNodeHook Reviewed By: angelayi Differential Revision: D57469157
shengfukevin
force-pushed
the
export-D57469157
branch
from
63855de
to
e7327b1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57469157 |
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
titaiwangms
pushed a commit
to titaiwangms/pytorch
that referenced
this pull request
May 28, 2024
Differential Revision: D57469157 Pull Request resolved: pytorch#126671 Approved by: https://github.com/angelayi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D57469157