refactor: remove superfluous 'async' from Promise executor #12468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
kkuegler
changed the title
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
kkuegler
changed the title
Lightning00Blade
approved these changes
May 21, 2024
This 'async' is not needed here, because there is no 'await' in its body. Having an async function as the executor for 'new Promise' is suboptimal, as it may swallow synchronous errors that might be thrown in the body. See https://stackoverflow.com/a/43050114/3394495
Lightning00Blade
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
a (potential) bugfix
Did you add tests for your changes?
no, I deemed it straightforward enough
If relevant, did you update the documentation?
n/a
Summary
This 'async' is not needed here, because there is no 'await' in its body.
Having an async function as the executor for 'new Promise' is suboptimal, as it swallows synchronous errors that might be thrown in the body.
See https://stackoverflow.com/a/43050114/3394495
Does this PR introduce a breaking change?
no
Other information
n/a