fix(oldfiles) : delete duplicated items in Windows #3103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/// Problem :
1) Duplicated items are listed in oldfiles because of neovim problem.
Example is like below.
c:\Users\USERS\test\telescope.lua
c:\Users\USERS/test/telescope.lua
c:/Users/USERS/test/telescope.lua
slash(/) makes neovim lua api cannot work properly in windows.
and string comparison don't distinguish it is the same path
This makes `file ~= current_file` condition cannot filter although it is same with the file
2) oldfiles show current session files also.
/// Solution :
1-1) Taking gsub('/', '\\') all files from neovim lua api.
1-2) Add additional condition which checks whether the file is listed in results (='results_other')
2) separate `results` variable to 2 parts.
First, 'results' as current session file list
Second, 'results_other' as old file list which are filtered unnecessary file
|
technically yes, seems like an easy fix, we can include this. but can you reduce the comments by like 95% we only have to mention it once why we do and the formatting doesnt align with our style, this needs to be addressed as well |
Conni2461
reviewed
May 27, 2024
| @@ -525,30 +525,50 @@ end | |||
| internal.oldfiles = function(opts) | |||
| opts = apply_cwd_only_aliases(opts) | |||
| opts.include_current_session = vim.F.if_nil(opts.include_current_session, true) | |||
| local has_win = vim.fn.has('win32') == 1 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Example is like below.
slash(/) makes neovim lua api cannot work properly in windows.
and string comparison don't distinguish it is the same path
This makes
file ~= current_filecondition cannot filter although it is same with the fileFixes #1683
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Taking gsub('/', '\') all files from neovim lua api.
Add additional condition which checks whether the file is listed in results (='results_other')
separate
resultsvariable to 2 parts.First, 'results' as current session file list
Second, 'results_other' as old file list which are filtered unnecessary file
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list relevant details about your configuration
There is nothing for the user to configure.
Configuration:
Checklist: