feat: add clerk integration in /next branch #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the Noodle Team on Vercel. A member of the Team first needs to authorize it. |
ixahmedxi
requested changes
May 18, 2024
There was a problem hiding this comment.
Thanks for the PR, there are some changes that need to be done however:
- add sign in / sign up pages for clerk.
- add clerk environment variables to env.ts.
- make the middleware only run on routes that start with /app because we wouldn't want to rate limit or check for authentication outside of that.
I also so see that you have also copied over the upstash rate limiting flow, I would change up the PR scope/title to match this then, something like feat: adds clerk & upstash integrations
|
@ixahmedxi I have made the changes you suggested, please let me know if anything more needs to be done:) |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ixahmedxi
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #363
This PR will add the clerk authentication in the /next branch.