src: replace kPathSeparator with std::filesystem
#53063
Open
+31
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
atlowChemi
reviewed
May 20, 2024
targos
reviewed
May 20, 2024
jasnell
reviewed
May 25, 2024
anonrig
force-pushed
the
remove-kpathseparator
branch
from
85b1a5a
to
3b9bb49
Compare
targos
reviewed
May 28, 2024
| @@ -13,6 +13,7 @@ | |||
| #include <unistd.h> | |||
| #endif | |||
|
|
|||
| #include <filesystem> | |||
There was a problem hiding this comment.
It seems wrong to include a header without using it in the file. Shouldn't it be included in node_report.cc ?
targos
reviewed
May 28, 2024
| @@ -3,6 +3,7 @@ | |||
|
|
|||
| #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS | |||
|
|
|||
| #include <filesystem> | |||
targos
reviewed
May 28, 2024
| @@ -7,6 +7,7 @@ | |||
| #error("This header can only be used when inspector is enabled") | |||
| #endif | |||
|
|
|||
| #include <filesystem> | |||
targos
reviewed
May 28, 2024
| @@ -57,6 +57,7 @@ | |||
| #include <array> | |||
| #include <atomic> | |||
| #include <cstdint> | |||
| #include <filesystem> | |||
targos
reviewed
May 28, 2024
| @@ -4,6 +4,7 @@ | |||
| #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS | |||
|
|
|||
| #include <cinttypes> | |||
| #include <filesystem> | |||
|
Error on Windows: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need
kPathSeparatoranymore sincestd::filesystem::path::preferred_separatorexists.cc @nodejs/cpp-reviewers @nodejs/fs