-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: add NODE_RUN_PACKAGE_JSON_PATH
env
#53058
cli: add NODE_RUN_PACKAGE_JSON_PATH
env
#53058
Conversation
6f6698a
to
9a745c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actual code LGTM
Feature wise, this only makes sense if we support package.json
being outside the current folder which we don't intentionally - which makes this feature kind of pointless imo?
@benjamingr I'll open a follow up pull request to add that as well :-) |
This comment was marked as outdated.
This comment was marked as outdated.
Would it make sense to mark this as |
Landed in 2aaeaa8 |
PR-URL: nodejs#53058 Refs: nodejs#52673 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Daniel Lemire <daniel@lemire.me>
This change adds a
NODE_RUN_PACKAGE_JSON_PATH
environment variable when it's executed withnode --run
. This is required for cli runners to know the context of the task they are running. More information can be found in the reference issue.Ref: #52673
cc @nodejs/cpp-reviewers