Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove nix flakes #28863

Merged
merged 1 commit into from
May 23, 2024
Merged

build: remove nix flakes #28863

merged 1 commit into from
May 23, 2024

Conversation

dundargoc
Copy link
Member

@dundargoc dundargoc commented May 20, 2024

It does not work and we don't plan on maintaining these anymore.

The flake files are being moved to
nix-community/neovim-nightly-overlay#483
instead.

@github-actions github-actions bot added the build building and installing Neovim using the provided scripts label May 20, 2024
It does not work and we don't plan on maintaining these anymore.

The flake files are being moved to
nix-community/neovim-nightly-overlay#483
instead.
@dundargoc dundargoc marked this pull request as ready for review May 20, 2024 09:24
Copy link
Member

@teto teto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a nice update possible nix-community/neovim-nightly-overlay#483 (comment) .
I will try to do the whole update/annoucements today and will merge this afterwards if that's ok with you. Having the flake disappear without proper announcements will annoy several people.

@teto
Copy link
Member

teto commented May 23, 2024

flake moved to nix-community in nix-community/neovim-nightly-overlay#516 .
Announced on reddit via crosspost on r/neovim and r/nixos at https://www.reddit.com/r/NixOS/comments/1cz67bm/flakenix_moved_from_githubneovimneovim_to/ .
And on nixos discourse at https://discourse.nixos.org/t/neovims-flake-nix-moved-to-nix-community/45887 .

Thanks to the core maintainers for accepting the flake to be committed in the first place, then merging nix PRs, and finally let nix users handle a graceful migration.
As development sped up, it became a hindrance to maintain so let's have neovim maintainers focus on neovim instead and the nix community build a richer neovim flake.

@teto teto merged commit 0e9c92a into neovim:master May 23, 2024
33 checks passed
@dundargoc dundargoc deleted the build/nix branch May 24, 2024 09:10
huangyingw pushed a commit to huangyingw/neovim that referenced this pull request May 31, 2024
It does not work and we don't plan on maintaining these anymore.

The flake files are being moved to
nix-community/neovim-nightly-overlay#516
instead.
@farnoy
Copy link

farnoy commented Jun 1, 2024

There are some orphaned references left in BUILD.md referring to this flake that's been removed.

@dundargoc
Copy link
Member Author

@farnoy wanna make a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build building and installing Neovim using the provided scripts platform:nix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants