fix(treesitter): get_node_text()
newline handling consistency
#28841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses the issue where
get_node_text()
behaves inconsistently between buffer and string sources.Resolves #28677
Changes
buf_range_get_text
to insert the trailing newline char.Rationale
My understanding is taht the range represents the part of the source to be captured. When set on a grid:
With the range being
Range = { 0, 3, 1, 0 }
. I would then expect\n
to be part of the output. Hence, I modified the behavior of the buffer source.nvim_buf_get_text
replaces\n
with\0
, and they are artificially recreated withtable.concat(lines, "\n")
. This function does not add the newline if there's only one input or if the last input is a newline. I added logic to remember if the part of the buffer to release ends with a newline to add it later.Note to reviewers
Please feel free to correct me if my understanding is incorrect. I would be happy to discuss it further.