Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue where defaultLinesDiffComputer does not pass in the timeout variable #213035

Merged
merged 1 commit into from
May 27, 2024
Merged

Fix an issue where defaultLinesDiffComputer does not pass in the timeout variable #213035

merged 1 commit into from
May 27, 2024

Conversation

CharlesHGong
Copy link
Contributor

@CharlesHGong CharlesHGong commented May 19, 2024 •
edited by hediet

Fixes #213034

This caller is missing to pass in the timeout variable.
Otherwise it won't respect the maxComputationTimeMs option that was passed in in computeDiff

The definition of the myersDiffingAlgorithm.compute looks like this

compute(seq1: ISequence, seq2: ISequence, timeout: ITimeout = InfiniteTimeout.instance)

@CharlesHGong
Copy link
Contributor Author

cc @hediet the last editor of the line.

@Yoyokrazy Yoyokrazy assigned hediet and unassigned Yoyokrazy May 20, 2024
hediet
hediet approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@hediet hediet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hediet hediet enabled auto-merge (squash) May 27, 2024 16:37
@hediet hediet added this to the May 2024 milestone May 27, 2024
@hediet hediet merged commit dccb86c into microsoft:main May 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hediet hediet hediet approved these changes

@sandy081 sandy081 sandy081 approved these changes

Assignees

@hediet hediet

Labels
triage-needed
Projects
None yet
Milestone
May 2024
Development

Successfully merging this pull request may close these issues.

DefaultLinesDiffComputer did not pass timeout as an option
5 participants
@CharlesHGong @hediet @sandy081 @Yoyokrazy @VSCodeTriageBot