Tiny improvements to Diagram Syntax sidebar #5532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5532 +/- ##
=======================================
Coverage 5.73% 5.73%
=======================================
Files 277 277
Lines 41988 41988
Branches 515 515
=======================================
Hits 2409 2409
Misses 39579 39579
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sidharthv96
approved these changes
May 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@sidharthv96 is develop broken? |
|
@TWiStErRob, Thank you for the contribution! |
|
The E2E tests are a bit flaky, with the baseline images used. Been planning to look into it, but didn't get time yet. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Improving this:
📏 Design Decisions
The titles of the sections on the website should be human friendly. "Zenuml" is not, as it looks like a word, so capitalized UML to call out what it's meant to say. "XYChart" is a class name, the opened page shows "XY Chart" to match all the other sections which have names closer to the actual page contents.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch