Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Desktop: Fix eslint issues and strengthen types in NoteEditor.tsx #10449

Merged
merged 2 commits into from
May 21, 2024
Merged

Chore: Desktop: Fix eslint issues and strengthen types in NoteEditor.tsx #10449

merged 2 commits into from
May 21, 2024

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented May 20, 2024 •
edited

Summary

This pull request removes several eslint-disable-next-lines and fixes the corresponding issues in NoteEditor.tsx. This should make it easier to debug, add logging for, and fix NoteEditor-related issues (e.g. #10447, #8960).

Testing plan

  1. Open a note in the markdown editor.
  2. Change the note's title.
  3. Verify that the title is updated in the note list.
  4. Switch to the rich text editor.
  5. Link to another note by dropping the note into the rich text editor.
  6. Ctrl+Click on the link.
  7. Add new content to the end of the note.
  8. Go back to the previous note.
  9. Go forward.
  10. Verify that scroll is preserved.
  11. Open the revision viewer.
  12. Close the revision viewer.

This has been tested successfully on Ubuntu 24.04.

@laurent22 laurent22 merged commit 652add9 into laurent22:dev May 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@personalizedrefrigerator @laurent22