Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Bumps github.com/creack/pty from 1.1.11 to 1.1.17 #3581

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

znley
Copy link

@znley znley commented May 20, 2024

This helps build and use lazygit on LoongArch64(a risc architecture).

  • PR Description

  • Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

This helps build and use lazygit on LoongArch64(a risc architecture).
@stefanhaller
Copy link
Collaborator

1.1.17 is from Oct 2021; any reason why you are not going all the way to the current release (v1.1.21)?

@znley
Copy link
Author

znley commented May 20, 2024

1.1.17 is from Oct 2021; any reason why you are not going all the way to the current release (v1.1.21)?

@stefanhaller I choose a version closer to the original. If possible, I can upgrade it to the latest version.

@stefanhaller
Copy link
Collaborator

I don't have an opinion really, I was just curious.

To be honest, I'm unsure how to go about testing this. CI is green, but that doesn't tell us much as our integration tests only run on Linux. It seems that some manual testing on different platforms would be needed. @jesseduffield Any thoughts about that?

Somewhat related is the vague idea whether we want to try switching to aiopty which is very new but seems to support Windows better.

@znley
Copy link
Author

znley commented May 21, 2024

@stefanhaller I tested it on loongarch64-linux. lazygit runs very well. Golang has officially supported loongarch64 (alias loong64) since 1.19. I think there is no problem with this.

@jesseduffield
Copy link
Owner

@stefanhaller I agree: we would need to do some manual testing with this. aiopty is notable for having windows support, though it is a very new repo with only two commits and only a single issue i.e. it hasn't been battle tested by real users. I'm still holding out hope for creack's repo getting that windows support PR across the line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants