Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus on local commits view after moving code into new commit #3577

Conversation

AzraelSec
Copy link
Contributor

@AzraelSec AzraelSec commented May 19, 2024

  • PR Description

This PR forces lazygit to focus to the Commits view after moving a custom (partial) patch in a new commit.

This closes #3200.

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

Copy link
Collaborator

@stefanhaller stefanhaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM. This is a very useful improvement.

Just one question below.

@AzraelSec AzraelSec force-pushed the refocus-commits-view-after-moving-custom-patch-into-new-commit branch from 4a25439 to 00e8d10 Compare May 20, 2024 17:11
@AzraelSec AzraelSec force-pushed the refocus-commits-view-after-moving-custom-patch-into-new-commit branch from 00e8d10 to 5af0ea8 Compare May 20, 2024 17:15
@AzraelSec
Copy link
Contributor Author

Thanks for taking the time to review this PR, @stefanhaller. I've addressed your comment and rebased the branch on the latest master.

@stefanhaller stefanhaller added the enhancement New feature or request label May 20, 2024
@stefanhaller
Copy link
Collaborator

Great, thanks. I used the "Move patch into new commit" several times today, and it annoyed me every time that it didn't show the commits afterwards. Nice that we have this now.

@stefanhaller stefanhaller merged commit 6343fb5 into jesseduffield:master May 20, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focus commits view after moving custom patch into new commit
2 participants