-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert solax to use DataUpdateCoordinator #117767
Conversation
fixes #109968 I do not have this integration and cannot test this change.
Hey there @squishykid, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
I know a guy who can help, I'm asking if he's able to test |
Rip, sadly he isn't able to |
@Darsstar and @brew-your-own recently opened PRs for this integration, maybe they're able to lend a hand :) |
I am currently updating docker, after which I will test it as best I can 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bdraco 👍
../Frenck
thanks |
Proposed change
There is a race here where the background task finishes before the entities can be added. The integration stores entities in a shared container and than mutates their state externally. We should use a DataUpdateCoordinator instead.
I do not have this integration and cannot test this change.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: