Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Monzo pot transfer service #117713

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

Add Monzo pot transfer service #117713

wants to merge 9 commits into from

Conversation

JakeMartin-ICL
Copy link
Contributor

Proposed change

Adds a pot transfer service to the new Monzo integration (#101731), allowing users to move money between their bank accounts and savings pots.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@JakeMartin-ICL JakeMartin-ICL mentioned this pull request May 18, 2024
Draft
8 tasks
@JakeMartin-ICL JakeMartin-ICL marked this pull request as draft May 19, 2024 15:31
@JakeMartin-ICL JakeMartin-ICL marked this pull request as ready for review May 19, 2024 16:23
@MartinHjelmare MartinHjelmare changed the title Monzo integration: Add pot transfer service Add Monzo pot transfer service May 19, 2024
zweckj
zweckj suggested changes May 20, 2024
View reviewed changes
homeassistant/components/monzo/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/monzo/services.py Show resolved Hide resolved
tests/components/monzo/test_services.py Outdated Show resolved Hide resolved
tests/components/monzo/test_services.py Outdated Show resolved Hide resolved
zweckj
zweckj approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@zweckj zweckj left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍 Let's wait for a maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zweckj zweckj zweckj approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
by-code-owner cla-signed has-tests integration: monzo new-feature Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JakeMartin-ICL @zweckj