Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: convert es6 to basic javascript tests to Playwright #54882

Closed
wants to merge 1 commit into from
Closed

feat: convert es6 to basic javascript tests to Playwright #54882

wants to merge 1 commit into from

Conversation

Sembauke
Copy link
Member

@Sembauke Sembauke commented May 20, 2024 •
edited

Checklist:

Closes #XXXXX

@github-actions github-actions bot added the scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. label May 20, 2024
@Sembauke Sembauke marked this pull request as ready for review May 20, 2024 16:24
@Sembauke Sembauke requested a review from a team as a code owner May 20, 2024 16:24
naomi-lgbt
naomi-lgbt reviewed May 20, 2024
View reviewed changes
e2e/es6-to-basic-javascript.spec.ts
Comment on lines +3 to +4
// To run this test locally you will need to run: pnpm run start-ci;
// Also, make sure that you have pm2 installed globally via: pnpm install -g pm2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this accurate?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my knowledge, yes, redirects don't work locally without it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda. It's possible to serve the client without installing pm2. You just pnpm run serve-ci from the client directory.

It is necessary if you run everything from the root of the repo, though, since that starts the server in production(ish) mode. Yep, it's messy.

@moT01 moT01 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label May 20, 2024
@Sembauke Sembauke mentioned this pull request May 21, 2024
Open
61 tasks
@Sembauke
Copy link
Member Author

I am going to block this one as #54897 does the same thing and I want to merge it in to that spec file.

@Sembauke Sembauke added status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels May 23, 2024
@Sembauke Sembauke closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

@ojeytonwilliams ojeytonwilliams Awaiting requested review from ojeytonwilliams

Assignees
No one assigned
Labels
scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Sembauke @ojeytonwilliams @naomi-lgbt @moT01