Refs #35189 -- Add a unique id to admin fieldsets. #18182
Closed
+73
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahboyce
force-pushed
the
unique_id_for_fieldset
branch
2 times, most recently
from
41a6d95
to
660c953
Compare
sarahboyce
force-pushed
the
unique_id_for_fieldset
branch
from
660c953
to
ba25ea5
Compare
sarahboyce
commented
May 20, 2024
| @@ -114,6 +116,21 @@ def __init__( | |||
| self.model_admin = model_admin | |||
| self.readonly_fields = readonly_fields | |||
|
|
|||
| @cached_property | |||
| def id(self): | |||
There was a problem hiding this comment.
I have been thinking about the id logic for a while, I think it would be good to have this logic pulled out. This might not be perfect but if we are fixing a non-unique fieldset id, we are not having to update multiple templates
@nessita I would be interested in what you think 👍
If you like it I can also add the aria-labelledby if this PR and then the other PR will fix the headers and collapse approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-XXXXX
Branch description
Provide a concise overview of the issue or rationale behind the proposed changes.
Checklist
mainbranch.