Fixed #35401 -- Documented the conditional page decorator. #18150
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahboyce
reviewed
May 10, 2024
docs/topics/http/decorators.txt
Outdated
| @@ -71,6 +71,11 @@ a :class:`django.http.HttpResponseNotAllowed` if the conditions are not met. | |||
|
|
|||
| Support for wrapping asynchronous view functions was added. | |||
|
|
|||
| .. function:: conditional_page() | |||
There was a problem hiding this comment.
I think this should be defined in the Conditional view processing section below rather than this section.
There is also a Conditional View Processing topic docs/topics/conditional-view-processing.txt, I'm wondering if this should be described over there too 🤔
There was a problem hiding this comment.
Hey @sarahboyce , I was thinking a link to Conditional GET middleware in Comparing conditional processing would be enough to guide someone to the conditional page decorator.
sarahboyce
force-pushed
the
ticket_35401
branch
2 times, most recently
from
ae547d6
to
44055e0
Compare
sarahboyce
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentioned the use of the conditional page decorator to provide functionality for Conditional for
ConditionalGetMiddleware on individual views, also mentioned the use of csrf_protect decorator to add protection of CsrfViewMiddleware to a view.
Trac ticket number
ticket-35401
Branch description
Provide a concise overview of the issue or rationale behind the proposed changes.
Checklist
mainbranch.