Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ResolvedCall.isCalling #7317

Merged
merged 3 commits into from
May 21, 2024
Merged

Conversation

3flex
Copy link
Member

@3flex 3flex commented May 20, 2024

This was only used by functions in this utils file, which have been refactored to remove its usage.

3flex added 2 commits May 20, 2024 13:28
This was only used by functions in this utils file.
@detekt-ci detekt-ci added the api label May 20, 2024
@detekt-ci
Copy link
Collaborator

detekt-ci commented May 20, 2024

Warnings
⚠️ It looks like this PR contains functional changes without a corresponding test.

Generated by 🚫 dangerJS against 4c5dead

@3flex 3flex added psi-utils breaking change Marker for breaking changes which should be highlighted in the changelog labels May 20, 2024
@3flex 3flex added this to the 2.0.0 milestone May 20, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.80%. Comparing base (f92f8ab) to head (4c5dead).
Report is 12 commits behind head on main.

Files Patch % Lines
...gitlab/arturbosch/detekt/rules/KtCallExpression.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7317      +/-   ##
============================================
+ Coverage     84.76%   84.80%   +0.04%     
- Complexity     3992     3993       +1     
============================================
  Files           578      576       -2     
  Lines         12026    12014      -12     
  Branches       2477     2473       -4     
============================================
- Hits          10194    10189       -5     
+ Misses          606      598       -8     
- Partials       1226     1227       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@3flex 3flex enabled auto-merge (squash) May 21, 2024 03:10
@3flex 3flex merged commit 1aaa6ab into detekt:main May 21, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api breaking change Marker for breaking changes which should be highlighted in the changelog psi-utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants