fix(ext/webgpu): Allow depthClearValue
to be undefined when depthLoadOp
is not "clear"
#23850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implemention would panic at
op_webgpu_command_encoder_begin_render_pass
with legal JavaScript code, becauseGpuRenderPassDepthStencilAttachment
requiredepth_clear_value
to always appear.The current WebGPU specification says1
The modification is tiny and easy to understand. Should I open a issue and/or add a unit test?
Footnotes
https://gpuweb.github.io/gpuweb/#dom-gpurenderpassdepthstencilattachment-depthclearvalue ↩