-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #14376: Added JAR generation config in maven-source to replace OSS parent pom #14642
base: master
Are you sure you want to change the base?
Conversation
I need a few clarifications please....
Clarity on these might help avoid problems with release. The build is however a success on my local. |
Please recheck why dry run of release phase did not catch fact of no javadoc. We have it in CI somewhere. Here is list of files we need https://repo1.maven.org/maven2/com/puppycrawl/tools/checkstyle/10.14.1/ |
1eee004
to
ddf428e
Compare
ddf428e
to
8a94a22
Compare
8a94a22
to
fb8f038
Compare
@romani , I think that might have something to do with parameter
Unfortunately, no. The plugin config seems to be running but is not bundling jar. This issue seems to be killing a lot of my productive hours 😞 |
abandon this PR for now, we can come back to it at any point of time in future, in future you will be more experienced and you will handle it. |
Sure, I will temporarily put this on hold until Gsoc or until some new thought comes to my mind :) |
If we are abandoning this, please close it, Github keeps a reference to this code forever. |
@MANISH-K-07 , please find time to finish this PR |
Aims to close #14376
@romani , @nrmancuso , This PR is a Follow-up of #14397 in response to #14376 (comment)
In order to remove the parent pom usage, we needed to apply the parent pom's plugin config. See https://github.com/sonatype/oss-parents/blob/master/codehaus-parent/pom.xml for this configuration.
We also had problems with release :
https://github.com/checkstyle/checkstyle/actions/runs/8066068513/job/22033791002#step:6:399
After digging in, I found that we had a dummy maven-source-plugin for build helpin our pom which was fine until we used oss parent. I believe this is the root cause for previous failures.
For JAR generation, I have introduced related configs to the plugins to execute.
https://maven.apache.org/plugins/maven-source-plugin/
Specified goals :
jar
andtest-jar
,jar-no-fork