Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #14376: Added JAR generation config in maven-source to replace OSS parent pom #14642

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MANISH-K-07
Copy link
Contributor

@MANISH-K-07 MANISH-K-07 commented Mar 11, 2024

Aims to close #14376

@romani , @nrmancuso , This PR is a Follow-up of #14397 in response to #14376 (comment)

In order to remove the parent pom usage, we needed to apply the parent pom's plugin config. See https://github.com/sonatype/oss-parents/blob/master/codehaus-parent/pom.xml for this configuration.

We also had problems with release :
https://github.com/checkstyle/checkstyle/actions/runs/8066068513/job/22033791002#step:6:399

Error: ROR]   Rule "javadoc-staging" failures
Error: ROR]     * Missing: no javadoc jar found in folder '/com/puppycrawl/tools/checkstyle/10.14.0'

After digging in, I found that we had a dummy maven-source-plugin for build helpin our pom which was fine until we used oss parent. I believe this is the root cause for previous failures.

      <!-- Generate test sources as well as main sources. -->
      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-source-plugin</artifactId>
      </plugin>

For JAR generation, I have introduced related configs to the plugins to execute.

https://maven.apache.org/plugins/maven-source-plugin/
Specified goals : jar and test-jar , jar-no-fork

@MANISH-K-07
Copy link
Contributor Author

MANISH-K-07 commented Mar 11, 2024

I need a few clarifications please....

  1. I wasn't sure why our maven-jar-plugin only has test goal specified ?
    Why are we bundling only test sources into the jar archive ??
    Why don't we need main sources bundled into .class files ?

    <goal>test-jar</goal>

  2. Also, I couldn't completely understand our GnuPG plugin dependency
    https://maven.apache.org/plugins/maven-gpg-plugin/
    Are we currently signing our artifacts or not ? We seem to be using the gpg plugin but I don't understand how

    <artifactId>maven-gpg-plugin</artifactId>

Clarity on these might help avoid problems with release. The build is however a success on my local.

@MANISH-K-07 MANISH-K-07 changed the title Issue #14376: Added JAR generation to maven-source Issue #14376: Added JAR generation config in maven-source to replace OSS parent pom Mar 11, 2024
@romani
Copy link
Member

romani commented Mar 14, 2024

Please recheck why dry run of release phase did not catch fact of no javadoc.

We have it in CI somewhere.
If you run dry run, do you see javadoc zip, can you share list of jar/zip we have.

Here is list of files we need https://repo1.maven.org/maven2/com/puppycrawl/tools/checkstyle/10.14.1/

@MANISH-K-07
Copy link
Contributor Author

MANISH-K-07 commented Mar 14, 2024

Please recheck why dry run of release phase did not catch fact of no javadoc.

@romani , I think that might have something to do with parameter failOnWarnings unspecified for maven-javadoc-plugin

If you run dry run, do you see javadoc zip, can you share list of jar/zip we have.

Unfortunately, no. The plugin config seems to be running but is not bundling jar.
I have added all possibly related configs but still am missing something here....

This issue seems to be killing a lot of my productive hours 😞

@romani
Copy link
Member

romani commented Mar 15, 2024

This issue seems to be killing a lot of my productive hours 😞

abandon this PR for now, we can come back to it at any point of time in future, in future you will be more experienced and you will handle it.

@MANISH-K-07
Copy link
Contributor Author

This issue seems to be killing a lot of my productive hours 😞

abandon this PR for now, we can come back to it at any point of time in future, in future you will be more experienced and you will handle it.

Sure, I will temporarily put this on hold until Gsoc or until some new thought comes to my mind :)
Please don't close this PR, I don't want this issue to be gone unnoticed or lost in time. An open (draft) PR will keep reminding me that I've left a pending issue.

@nrmancuso
Copy link
Member

If we are abandoning this, please close it, Github keeps a reference to this code forever.

@romani
Copy link
Member

romani commented May 11, 2024

@MANISH-K-07 , please find time to finish this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken maven-enforcer configuration
3 participants