-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
broken maven-enforcer configuration #14376
broken maven-enforcer configuration #14376
Comments
I thought parent pom was required to be able to deploy artifacts to maven central. Is it not an issue anymore? |
That was true in the past, but is deprecated now: https://central.sonatype.org/publish/publish-maven/#deprecated-oss-parent. The paragraphs below and above show how to reach the same by putting the necessary information into your own pom. |
Let's just remove parent pom if this doesn't cause any issues. |
Isn't this "bugging"? 😂 We still need approval from @romani on this issue. |
we reverted changes as it caused problems for release - https://github.com/checkstyle/checkstyle/actions/runs/8066068513/job/22033791002#step:6:399
|
This seems deeper than what I had anticipated .. @romani , Is there anything I could do to help ? |
This reverts commit 974367d.
we still need to investigate and fix this problem. |
looks like parent pom defined some config for javadoc generation, and we need to restore it. |
Sure, I'll try to browse through the sonatype-oss pom to root out the issue !! Is there any way to test the config enhancement once its done? Since the CI we use obviously couldn't help with this |
@romani ? It would be helpful if I could test my changes for working.. |
The POM has 2 different maven-enforcer configurations, because the parent (sonatype-oss) and the checkstyle pom.xml use different execution ids.
This is from Sonatype parent pom.xml:
From checkstyle pom.xml:
checkstyle/pom.xml
Lines 1352 to 1356 in 50683f1
Note the 2 different ids. This is problematic for instance when executing the versions plugin:
which wrongly complains about no maven version being defined:
That's because it uses the first value it finds in the effective pom, which is the one from the Sonatype parent.
To fix this, I would recommend binding the execution of the Sonatype defined id
enforce-maven
against phasenone
(to effectively disable it). Alternatively the checkstyle pom execution id could be changed toenforce-maven
to overwrite the parent configuration.UPDATE: If I get it right, that parent POM is deprecated, so just removing it would of course also fix this issue: https://github.com/sonatype/oss-parents
The text was updated successfully, but these errors were encountered: