Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

International Leave this site options #898

Merged
merged 4 commits into from May 11, 2024

Conversation

anmol-fzr
Copy link
Contributor

Issue :

Issue number: 888
Issue link: #888

What changes did you make?

Added International to Leave this site options, now wikipedia and google links open respective to user's current language

Why did you make the changes?

This feature was obvious to have and also had an issue on the repo

Did you run tests?

I ran tests

Copy link

vercel bot commented May 10, 2024

@anmol-fzr is attempting to deploy a commit to the Chayn Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bloom-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2024 4:19pm

@eleanorreem
Copy link
Contributor

Hi @anmol-fzr, this looks great from an initial look. As per our Contributor Guidelines, to accept your PR, you need to claim an issue. I can't seem to tag you without you commenting on the issue. This helps us keep track and document open-source contributions. 😄 Can you comment on the issue and then I can properly reviewand authorise the workflow 🎉

@anmol-fzr
Copy link
Contributor Author

@eleanorreem Hopefully this PR is ready to be merged. Merge this if possible if not please inform so that i can make suitable changes

@eleanorreem
Copy link
Contributor

eleanorreem commented May 11, 2024

Hey @anmol-fzr, Thanks for your contribution! this PR is failing to build unfortunately. The error I get looks like the screen shot below. Running yarn build and running the yarn lint will ensure you don't encounter these errors. The error comes from the use of double quotes where single should be used. Let me know if you have any questions. Thanks again!
Screenshot 2024-05-11 at 17 00 48

@anmol-fzr
Copy link
Contributor Author

@eleanorreem I have fixed the Linting Error you mentioned while building this project i also encountered error about "@mui/system" library i didn't changed any other file as this library is used in the code on the official repo, assuming this won't cause errors on build.

@eleanorreem eleanorreem merged commit 6235e55 into chaynHQ:develop May 11, 2024
5 checks passed
@eleanorreem
Copy link
Contributor

eleanorreem commented May 11, 2024

Thanks for this! All worked well ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants