fix: return 200 status code #15134
Merged
fix: return 200 status code #15134
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (05/20/24)1 reviewer was added to this PR based on Keith Williams's automation. |
Udit-takkar
commented
May 20, 2024
| }) | ||
| ); | ||
| return res.status(404).send({ message: "Booking reference not found" }); |
There was a problem hiding this comment.
if daily webhook return non 20x(status code) response 3 consecutive times then it wouldn't get triggered again.
There was a problem hiding this comment.
we shouldn't block webhooks for everyone if it didn't work on some edge case.
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Udit-takkar
commented
May 20, 2024
| @@ -87,7 +87,7 @@ export const CalAiTranscribe = () => { | |||
| textShadow: "0 0 20px black, 0 0 20px black, 0 0 20px black", | |||
| }} | |||
| ref={transcriptRef} | |||
| className="max-h-full overflow-x-hidden overflow-y-scroll p-8 text-center text-white"> | |||
| className="max-h-full overflow-x-hidden overflow-y-scroll p-2 text-center text-white"> | |||
There was a problem hiding this comment.
Regression from #15044. This div was blocking the start recording button
Current Playwright Test Results Summary✅ 321 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/21/2024 07:16:55am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: c865a20 Started: 05/21/2024 07:13:34am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Change stripe presented currency Should be able to change currency
Retry 1 • Initial Attempt |
0% (0)0 / 197 runsfailed over last 7 days |
0.51% (1)1 / 197 runflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user Different Locations Tests Can add Link Meeting as location and book with it
Retry 1 • Initial Attempt |
0.45% (1)1 / 223 runfailed over last 7 days |
15.25% (34)34 / 223 runsflaked over last 7 days |
|
Event Types tests -- legacy user Different Locations Tests can select 'display on booking page' option when multiple organizer input type are present
Retry 1 • Initial Attempt |
0.46% (1)1 / 219 runfailed over last 7 days |
5.48% (12)12 / 219 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 4 Flakes
Top 1 Common Error Messages
|
|
4 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Namespacing Inline Embed Add inline embed using a namespace without reload
Retry 1 • Initial Attempt |
0% (0)0 / 213 runsfailed over last 7 days |
65.26% (139)139 / 213 runsflaked over last 7 days |
|
Namespacing Different namespaces can have different init configs
Retry 1 • Initial Attempt |
0% (0)0 / 212 runsfailed over last 7 days |
63.21% (134)134 / 212 runsflaked over last 7 days |
|
Namespacing Inline Embed Double install Embed Snippet with inline embed using a namespace
Retry 1 • Initial Attempt |
0.47% (1)1 / 213 runfailed over last 7 days |
62.91% (134)134 / 213 runsflaked over last 7 days |
|
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace)
Retry 1 • Initial Attempt |
0% (0)0 / 213 runsfailed over last 7 days |
65.73% (140)140 / 213 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1 • Initial Attempt |
0.47% (1)1 / 212 runfailed over last 7 days |
29.72% (63)63 / 212 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 3 Flakes
Top 1 Common Error Messages
|
|
3 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can update a users email (verification enabled)
Retry 1 • Initial Attempt |
39.34% (96)96 / 244 runsfailed over last 7 days |
32.79% (80)80 / 244 runsflaked over last 7 days |
|
Update Profile Can verify the newly added secondary email
Retry 1 • Initial Attempt |
2.44% (6)6 / 246 runsfailed over last 7 days |
21.95% (54)54 / 246 runsflaked over last 7 days |
|
Update Profile Can resend verification link if the secondary email is unverified
Retry 1 • Initial Attempt |
11.38% (28)28 / 246 runsfailed over last 7 days |
31.30% (77)77 / 246 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg -- future Can create a booking for Round Robin EventType
Retry 2 • Retry 1 • Initial Attempt |
9.73% (22)22 / 226 runsfailed over last 7 days |
24.78% (56)56 / 226 runsflaked over last 7 days |
|
Teams - NonOrg -- legacy Can create a booking for Round Robin EventType
Retry 1 • Initial Attempt |
7.96% (18)18 / 226 runsfailed over last 7 days |
30.97% (70)70 / 226 runsflaked over last 7 days |
📄 packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced
Retry 1 • Initial Attempt |
19.65% (45)45 / 229 runsfailed over last 7 days |
33.19% (76)76 / 229 runsflaked over last 7 days |
📄 apps/web/playwright/organization/booking.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Bookings Team Event Can create a booking for Round Robin EventType
Retry 1 • Initial Attempt |
6.82% (15)15 / 220 runsfailed over last 7 days |
30.91% (68)68 / 220 runsflaked over last 7 days |
PeerRich
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Not a bug but while testing recording locally app.cal.com/api/recorded-daily-video get triggered and as booking reference is not found in prod db it would return 404
#15078 (comment)
Mandatory Tasks (DO NOT REMOVE)