-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add organization logo to org dynamic events #15082
fix: Add organization logo to org dynamic events #15082
Conversation
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (05/16/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 3 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/21/2024 02:09:21pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: eb50662 Started: 05/21/2024 02:08:46pm UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced
Retry 2 • Retry 1 • Initial Attempt |
20.24% (50)50 / 247 runsfailed over last 7 days |
34.01% (84)84 / 247 runsflaked over last 7 days |
// eslint-disable-next-line playwright/no-skipped-test | ||
test.skip("it contains the right event details", async ({ page }) => { | ||
const response = await page.goto(`http://acme.cal.local:3000/owner1+member1`); | ||
expect(response?.status()).toBe(200); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: this is a redundant assertion
the next expects will always be false if this page is not a 200
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also should this be a skip?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this PR do?