Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add organization logo to org dynamic events #15082

Merged
merged 3 commits into from
May 21, 2024

Conversation

emrysal
Copy link
Contributor

@emrysal emrysal commented May 16, 2024

What does this PR do?

  • Previous fix removed the duplicate avatar, but didn't bring in the org logo. This adjusts the dynamic logic to return the correct profile.

@graphite-app graphite-app bot requested a review from a team May 16, 2024 16:37
Copy link
Contributor

github-actions bot commented May 16, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added core area: core, team members only foundation labels May 16, 2024
@dosubot dosubot bot added event-types area: event types, event-types organizations area: organizations, orgs 🐛 bug Something isn't working labels May 16, 2024
Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 10:20am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 10:20am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 10:20am

Copy link

graphite-app bot commented May 16, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (05/16/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented May 16, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented May 17, 2024

Current Playwright Test Results Summary

✅ 3 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/21/2024 02:09:21pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: eb50662

Started: 05/21/2024 02:08:46pm UTC

⚠️ Flakes

📄   packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced
Retry 2Retry 1Initial Attempt
20.24% (50) 50 / 247 runs
failed over last 7 days
34.01% (84) 84 / 247 runs
flaked over last 7 days

View Detailed Build Results


// eslint-disable-next-line playwright/no-skipped-test
test.skip("it contains the right event details", async ({ page }) => {
const response = await page.goto(`http://acme.cal.local:3000/owner1+member1`);
expect(response?.status()).toBe(200);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: this is a redundant assertion

the next expects will always be false if this page is not a 200

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also should this be a skip?

Copy link
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2024-05-21 at 11 26 26
Tested and works well nice job

@emrysal emrysal merged commit 99d4461 into main May 21, 2024
41 checks passed
@emrysal emrysal deleted the bugfix/add-organization-logo-in-dynamic-type-avatars branch May 21, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working core area: core, team members only event-types area: event types, event-types foundation organizations area: organizations, orgs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants