feat(router): export function to run guards serially #55890
Conversation
| * @param guards An array of functional guards that should be executed in the declared order. | ||
| * @returns The combined functional guard. | ||
| */ | ||
| export function runSerially( |
There was a problem hiding this comment.
In order for this to be part of the public API, you also have to export it from packages/router/src/index.ts and then run the command to accept the new public API golden: yarn bazel run //packages/router:router_api.accept
There was a problem hiding this comment.
Would be great to also add @publicApi, usually at the last of the JSDoc.
There was a problem hiding this comment.
Thanks for the quick feedback. I will use the same JSDoc footer section as in the other functions within this file.
atscott
added
area: router
target: minor
pkozlowski-opensource
added
the
action: cleanup
|
This PR will need rebase after all the recent merges. |
|
Deployed adev-preview for 39f4984 to: https://ng-dev-previews-fw--pr-angular-angular-55890-adev-prev-prhspsgj.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
When multiple guards are defined for a route, they run concurrently by default. There are use cases in which it is desirable to compose guards serially, e.g., when one guard depends on pre-conditions established by another one. A basic `runSerially` function existed in the tests already. This commit makes the function importable and modifies it to handle more edge cases that will occur in practical use.
junpls
force-pushed
the
feat/serial-guards
branch
from
1e09b6b
to
39f4984
Compare
atscott
removed
the
action: cleanup
When multiple guards are defined for a route, they run concurrently by default. There are use cases in which it is desirable to compose guards serially, e.g., when one guard depends on pre-conditions established by another one. A basic
runSeriallyfunction existed in the tests already. This commit makes the function importable and modifies it to handle more edge cases that will occur in practical use.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
A helper function is added to compose functional guards serially.
Does this PR introduce a breaking change?