New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mecab, mecab-ipadic: fix build on Sonoma #171139
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocab
added
CI-no-fail-fast
Continue CI tests despite failing GitHub Actions matrix builds.
CI-no-bottles
Merge without publishing bottles
labels
May 8, 2024
github-actions
bot
added
the
missing license
Formula has a missing license which should be added
label
May 8, 2024
4 tasks
May be due to For example, Sonoma ARM64: ❯ otool -L mecab/0.996/bin/mecab
mecab/0.996/bin/mecab:
@@HOMEBREW_CELLAR@@/mecab/0.996/lib/libmecab.2.dylib (compatibility version 3.0.0, current version 3.0.0)
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1336.0.0)
/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 1600.151.0) Ventura ARM64: ❯ otool -L mecab/0.996/bin/mecab
mecab/0.996/bin/mecab:
@@HOMEBREW_CELLAR@@/mecab/0.996/lib/libmecab.2.dylib (compatibility version 3.0.0, current version 3.0.0)
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1319.0.0)
/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 1300.32.0)
/usr/lib/libiconv.2.dylib (compatibility version 7.0.0, current version 7.0.0) |
Must've been built with a bad version of Xcode. Here's one local build on Sonoma:
|
This should help prevent #171137.
carlocab
force-pushed
the
mecab-ipadic-test
branch
from
May 14, 2024 12:49
046e6c3
to
f91c48a
Compare
carlocab
changed the title
mecab-ipadic: update test
mecab, mecab-ipadic: fix build on Sonoma
May 14, 2024
We need new bottles because the ones built for Sonoma are broken. |
cho-m
approved these changes
May 15, 2024
🤖 An automated task has requested bottles to be published to this PR. |
github-actions
bot
added
the
CI-published-bottle-commits
The commits for the built bottles have been pushed to the PR branch.
label
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI-no-fail-fast
Continue CI tests despite failing GitHub Actions matrix builds.
CI-published-bottle-commits
The commits for the built bottles have been pushed to the PR branch.
missing license
Formula has a missing license which should be added
ready to merge
PR can be merged once CI is green
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?This should help prevent #171137.