Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use dev-net chain config for local node #2334

Merged
merged 27 commits into from
May 24, 2024
Merged

chore: use dev-net chain config for local node #2334

merged 27 commits into from
May 24, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented May 17, 2024 •
edited

Summary:

  • Updated the 2 chains config to use the same values from the dev-net.
  • Updated the base asset ID to be the same value as the dev-net.
  • Updated funding amounts within our tests, as the calculated fee value increased.

@Torres-ssf Torres-ssf self-assigned this May 17, 2024
@Torres-ssf Torres-ssf changed the title chore: use devenet chain config for local node chore: use dev-net chain config for local node May 17, 2024
@Torres-ssf Torres-ssf marked this pull request as ready for review May 22, 2024 19:18
Dhaiwat10
Dhaiwat10 approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@Dhaiwat10 Dhaiwat10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Torres-ssf
Copy link
Contributor Author

@nedsalk I wonder if merging this PR now will result in breaking #1356.

@nedsalk
Copy link
Contributor

nedsalk commented May 24, 2024

@Torres-ssf I don't think it will break because only the values of the configs changed, not the interface.

@nedsalk nedsalk enabled auto-merge (squash) May 24, 2024 07:20
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.79%(+0%) 70.77%(+0%) 76.99%(+0%) 79.89%(+0%)
Changed Files:

Coverage values did not change👌.

@nedsalk nedsalk merged commit 83bbb7f into master May 24, 2024
19 checks passed
@nedsalk nedsalk deleted the st/chore/update-local-chain-config branch May 24, 2024 12:18
@fuel-service-user fuel-service-user mentioned this pull request May 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@danielbate danielbate danielbate approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@Dhaiwat10 Dhaiwat10 Dhaiwat10 approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@Torres-ssf Torres-ssf

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Testnet configuration for local testnet
6 participants
@Torres-ssf @nedsalk @arboleya @danielbate @petertonysmith94 @Dhaiwat10