Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallets): no routes render on input amount #20111

Closed
BalogunofAfrica opened this issue May 20, 2024 · 2 comments · Fixed by #20112
Closed

fix(wallets): no routes render on input amount #20111

BalogunofAfrica opened this issue May 20, 2024 · 2 comments · Fixed by #20112
Assignees
@BalogunofAfrica

Comments

@BalogunofAfrica
Copy link
Contributor

BalogunofAfrica commented May 20, 2024 •
edited

Fixes the issue noted here #19953 (comment) introduced by this PR #19953.

"No routes found" is rendered every time there is an invalid amount:

It should only be rendered based on the flows in 1 and 2
@BalogunofAfrica BalogunofAfrica self-assigned this May 20, 2024
@BalogunofAfrica BalogunofAfrica mentioned this issue May 20, 2024
Merged
@vkjr
Copy link
Contributor

vkjr commented May 20, 2024

@BalogunofAfrica, I think it would be convenient if the problem details were moved from a linked comment to the description section of this issue, wdyt?

@BalogunofAfrica
Copy link
Contributor Author

@BalogunofAfrica, I think it would be convenient if the problem details were moved from a linked comment to the description section of this issue, wdyt?

Yeah makes sense. I have updated the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BalogunofAfrica BalogunofAfrica

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(wallets): no routes render on input amount status-im/status-mobile
2 participants
@vkjr @BalogunofAfrica