-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance issue on PRs with lots of changes (3rd issue) #7331
Comments
In my case I was able to use the 'identify feature' function to track the culprit down to |
I used "identify feature" and had to disable |
The profile suggests some code calls |
My guesses are:
There's an issue for the latter. I will try to look into that specifically and hope it magically solves at least half the issue. |
Ah I see, after just reading the context in older linked issues, I guess the root cause is features like |
I filed a Firefox bug about this situation as well, which links back to the discussion here. Even though this add-on is involved in the situation, there does seem to be some kind of core Firefox performance issue that is being triggered by this add-on's behaviour, so it's possible a future Firefox version may perform better here. I would imagine for the short term though, changing the add-on behaviour as suggested above is the quickest route to a fix. |
Thank you for filing the bug. Hopefully a mozillian can look into what the browser is spending cycles on, because I can't decipher its dev tools |
Mozillians have made some changes to Firefox which have now landed in the latest nightly version (2024-05-18), and I can confirm performance is much improved. 😄 For the PR I've been testing with, there's a 4 - 5x performance improvement with this Firefox change. The add-on features mentioned here (like |
Happy to hear that! Is there an issue with the selector? Can that be improved too? The AJAX I think just makes the issue more visible, but if a selector performs badly it will continue to do so on every DOM change. |
I wasn't entirely sure myself. After chatting with Mozillians about it, they said that anchoring For example, the |
I made some changes as suggested by @jryans in the upcoming 24.6.2 version. I'm closing this issue and I'll reopen another one in a couple of days to check how we're doing. As always, before reporting your issues, ensure you're on the latest (24.6.2 as of today) |
I opened #7404 if you still have any concerns. Thank you for your patience 🙏 |
Follows
If after v24.4.9 you still see performance issues, please "like" this issue.
Please do not leave "me too" comments
The text was updated successfully, but these errors were encountered: