Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmentation fault with torch.compile in torchchat #126669

Open
mikekgfb opened this issue May 20, 2024 · 2 comments
Open

Segmentation fault with torch.compile in torchchat #126669

mikekgfb opened this issue May 20, 2024 · 2 comments
Labels
module: aotinductor aot inductor needs reproduction Someone else needs to try reproducing the issue given the instructions. No action needed from user oncall: pt2 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@mikekgfb
Copy link
Contributor

mikekgfb commented May 20, 2024

馃悰 Describe the bug

https://github.com/pytorch/torchchat/actions/runs/9154013584/job/25163857442?pr=824

Average tokens/sec: 38.80
Memory used: 0.00 GB

  • python generate.py --checkpoint-path checkpoints/stories15M/stories15M.pt --device cpu --dtype float32 --temperature 1.0 --sequential-prefill --compile
    Using device=cpu AMD EPYC 7R32
    Loading model...
    Time to load model: 0.02 seconds

/exec: line 35: 4135 Segmentation fault python generate.py --checkpoint-path ${MODEL_PATH} --device cpu --dtype ${DTYPE} --temperature 1.0 --sequential-prefill --compile

Versions

Pytorch CI

cc @ezyang @msaroufim @bdhirsh @anijain2305 @chauhang @desertfire @chenyang78

@malfet malfet added needs reproduction Someone else needs to try reproducing the issue given the instructions. No action needed from user oncall: pt2 labels May 20, 2024
@malfet
Copy link
Contributor

malfet commented May 20, 2024

Issue as it's filed feels unactionable to me and probably should be closed. Fact that AOTI artifact can be used from Python, but not C++ suggest problem with C++ app rather than with AOTI runtime

@mlazos mlazos added the module: aotinductor aot inductor label May 22, 2024
@mlazos
Copy link
Contributor

mlazos commented May 22, 2024

cc @desertfire

@mlazos mlazos added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: aotinductor aot inductor needs reproduction Someone else needs to try reproducing the issue given the instructions. No action needed from user oncall: pt2 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

3 participants