Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fetch): allow UTF-8 in Location header #30904

Merged

Conversation

mxschmitt
Copy link
Member

This brings up the discussion if we want to post-process all the headers as UTF-8 as well.

Fixes #30903 (comment)

This comment has been minimized.

packages/playwright-core/src/server/fetch.ts Outdated Show resolved Hide resolved
@mxschmitt mxschmitt force-pushed the bugfix/fetch-allow-utf8-location-header branch from 190dd78 to b8470e8 Compare May 20, 2024 20:02

This comment has been minimized.

Signed-off-by: Max Schmitt <max@schmitt.mx>
@mxschmitt mxschmitt merged commit a93ad3d into microsoft:main May 21, 2024
28 of 29 checks passed
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › playwright.ct-react.spec.ts:253:5 › should pass "key" attribute from JSX in variable

2 flaky ⚠️ [firefox-page] › page/page-request-continue.spec.ts:481:3 › continue should not change multipart/form-data body
⚠️ [chromium] › components/splitView.spec.tsx:45:5 › should render horizontal split

27016 passed, 610 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: redirect in route.fetch may jump to a wrong url
2 participants