Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jx upgrade cli (and plugins) should verify the artifact before installing #8438

Open
ankitm123 opened this issue Oct 22, 2022 · 3 comments
Open

Comments

@ankitm123
Copy link
Member

ankitm123 commented Oct 22, 2022

Now that we are signing the artifacts, we should make jx upgrade cli verify the artifact before upgrading the version. This can be done using cosign verify-blob. Normally the way to verify blobs is this:

cosign verify-blob --key https://raw.githubusercontent.com/jenkins-x/jx/main/jx.pub --signature jx-linux-amd64.tar.gz.sig jx-linux-amd64.tar.gz

jx upgrade cli will do all this transparently.

Eventually we want to do this for all the plugins (they are not signed yet) and only install verified plugins in user's workstation,

For example, this does not verify the binary before installing:

jx project --help
Installing plugin jx-project version 0.2.54 for command jx project from https://github.com/jenkins-x-plugins/jx-project/releases/download/v0.2.54/jx-project-linux-amd64.tar.gz into /home/ankitm123/.jx3/plugins/bin
Deleted old plugin versions: [jx-project-0.0.153 jx-project-0.0.167 jx-project-0.0.178 jx-project-0.0.202 jx-project-0.2.11 jx-project-0.2.17 jx-project-0.2.2 jx-project-0.2.22 jx-project-0.2.23 jx-project-0.2.30 jx-project-0.2.4]
@ankitm123
Copy link
Member Author

@osamamagdy and @ankitm123 to look at this.

@osamamagdy
Copy link
Member

@ba11b0y
Copy link

ba11b0y commented Jan 4, 2023

Is this up for grabs? @ankitm123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants