Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAL-3766] Offer seats events invites everyone regardless their availibility schedule #15105

Open
olivierlambert opened this issue May 18, 2024 · 2 comments · May be fixed by #15171
Open

[CAL-3766] Offer seats events invites everyone regardless their availibility schedule #15105

olivierlambert opened this issue May 18, 2024 · 2 comments · May be fixed by #15171
Labels
🐛 bug Something isn't working High priority Created by Linear-GitHub Sync seats area: seats, guest meetings, multiple people teams area: teams, round robin, collective, managed event-types Urgent Created by Linear-GitHub Sync
Milestone

Comments

@olivierlambert
Copy link

olivierlambert commented May 18, 2024

Issue Summary

When using an event with "offer seats", despite setting a round robin attribution for the event, all the hosts are invited, regardless their own availability.

Steps to Reproduce

  1. Create an event with seats
  2. Have 2 hosts with their own availability (which are different/without overlap)
  3. Book a meeting at an hour where only one host is available
  4. Both hosts are invited

Actual Results

  • Both hosts are invited to the event despite their availability is incompatible with the booked slot

Expected Results

  • Only the available host should be invited, respecting their own availability

Technical details

  • Chrome/FF
  • Node.js 18
  • Cal v4.07

Evidence

Round robin enabled with 2 hosts:

image

image

But the invite:

image

CAL-3766

Copy link

dosubot bot commented May 18, 2024

To resolve the issue where both hosts are invited to an event despite differing availabilities, you'll need to adjust the logic in your application that assigns hosts to events, especially when using the "offer seats" option. Here's a focused approach to tackle this:

  1. Adjust Round Robin Logic with Availability Checks: Update the round robin assignment logic to include checks against each host's availability before sending out invites. This means integrating availability verification within the handleSeatsEventTypeOnBooking function or similar, ensuring that only hosts available at the event time are considered.

  2. Calendar Integration for Accurate Availability: Enhance how your system checks a host's availability by improving calendar integration. This involves making sure that any existing bookings are considered when assigning hosts to new events, preventing double bookings.

  3. Debugging and Testing: Implement detailed logging and develop automated tests that simulate various booking scenarios. This will help ensure that your scheduling system behaves as expected, correctly selecting available hosts for events.

  4. Rescheduling Logic: Make sure your application handles event rescheduling properly, updating the assigned host based on their current availability and updating the event details in both the system and the host's calendar.

  5. Automated Testing for Edge Cases: Develop tests for edge cases, such as overlapping host availabilities or rescheduling, to ensure your system can handle these scenarios gracefully.

  6. External Calendar Updates: Ensure that when an event is rescheduled or a host's assignment changes, the event details are correctly updated in any connected external calendars.

  7. Fallback Mechanisms for Errors: Implement mechanisms to handle scenarios where no hosts are available or other errors occur, such as notifying an administrator or suggesting alternative booking times to the user.

By refining your scheduling system's logic with these steps, you should be able to ensure that only the host who is available at the time of the booked meeting is invited, aligning with the expected behavior of the "offer seats" option and round robin attribution.

Details

Sources


About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

To continue the conversation, mention @dosu.

@dosubot dosubot bot added seats area: seats, guest meetings, multiple people 🐛 bug Something isn't working labels May 18, 2024
@rk9595
Copy link

rk9595 commented May 19, 2024

Can I take this issue?

@PeerRich PeerRich added the Urgent Created by Linear-GitHub Sync label May 20, 2024
@PeerRich PeerRich added this to the v4.2 milestone May 20, 2024
@PeerRich PeerRich changed the title Offer seats events invites everyone regardless their availibility schedule [CAL-3766] Offer seats events invites everyone regardless their availibility schedule May 20, 2024
@PeerRich PeerRich added High priority Created by Linear-GitHub Sync teams area: teams, round robin, collective, managed event-types Low priority Created by Linear-GitHub Sync and removed High priority Created by Linear-GitHub Sync Low priority Created by Linear-GitHub Sync labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working High priority Created by Linear-GitHub Sync seats area: seats, guest meetings, multiple people teams area: teams, round robin, collective, managed event-types Urgent Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants