-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debconf: set empty password value #83217
Open
Akasurde
wants to merge
2
commits into
ansible:devel
Choose a base branch
from
Akasurde:i83214
base: devel
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bug
This issue/PR relates to a bug.
needs_triage
Needs a first human triage before being processed.
module
This issue/PR relates to a module.
has_issue
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
labels
May 8, 2024
1 task
ansibot
removed
the
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
label
May 8, 2024
mkrizek
removed
the
needs_triage
Needs a first human triage before being processed.
label
May 14, 2024
Fixes: ansible#83214 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
ansibot
added
the
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
label
May 14, 2024
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
ansibot
removed
the
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
label
May 14, 2024
bcoca
reviewed
May 14, 2024
if dquestion == question and dvtype == vtype: | ||
if len(dvalue) >= 1: | ||
return dvalue[0] | ||
return '' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are changing the logic for not found, since desired_line will always be true when leaving the loop, the error handler will be wrong
ansibot
added
the
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
label
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes: #83214
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE