-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular: bad AbpTitleStrategy implementation #19806
Comments
Hi @antonGritsenko, this is ABP internal title strategy. It merges page name and project name and bind it to the title. For example if you create a project named If you didn't like this strategy you can create your own strategy. An example of creating custom
|
Yeah, but what's the point of such stratagy? 100% devs will change it because it useless. Why not to use same as you did on home page, just use localization? |
I dont think this is useless, it just adds |
Yeah, first part is great, I'm talking about second part :) |
Hi, @antonGritsenko so you are saying that the project name shouldn't exist in title. It should be only |
I'm talking about that project name is ugly. Usually it have no spaces, but contains several words. Will be great to use page title | app title where app title is also localized string. |
Here is what I meant:
|
Hi @antonGritsenko thank you for your feedback. #19834 |
Is there an existing issue for this?
Description
The AbpTitleStrategy have very weird implementation: it takes page title from the localization.defaultResourceName configuration, which is totally internal and always quite ugly.
From the docs"
Reproduction Steps
Expected behavior
Title is not ugly
Actual behavior
Title is ugly and can't be changed
Regression?
Yes (this is new in v8)
Known Workarounds
No
Version
8.1.1
User Interface
Angular
Database Provider
EF Core (Default)
Tiered or separate authentication server
Tiered
Operation System
Windows (Default)
Other information
No response
The text was updated successfully, but these errors were encountered: