Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telescope dependencies are missing from windows installations #4450

Open
The-Noumeno opened this issue Dec 26, 2023 · 6 comments
Open

Telescope dependencies are missing from windows installations #4450

The-Noumeno opened this issue Dec 26, 2023 · 6 comments

Comments

@The-Noumeno
Copy link

Problem description

I recently installed lunar vim under Windows, and I immediately noticed that telescope was not installing correctly, turns out you need to install ripgrep (and also sharkdp/fd), otherwise telescope won't work properly. I think this should be included into the installation instructions for Windows explicitely (in the download page on the main site at least), because it is not at all obvious at a first glance!

LunarVim version

Neovim version (>= 0.9.1)

0.9

Terminal name

Powershell 7+

Operating system/version

Windows

Steps to reproduce

Simply install with the script provided on the main page on a fresh install Windows machine

Screenshots

No response

@The-Noumeno The-Noumeno added the bug Something isn't working label Dec 26, 2023
@AndrewJRichardson
Copy link

Much of the windows guide needs revisiting here are the issues I encountered on top of the ones you have mentioned:

If you use make like the prerequisites suggest then there is also an unmentioned requirement to have gcc or clang installed to compile telescope-fzf-native.nvim.

The config file for the current stable version (1.3) is broken by default in Windows. This was seemingly fixed in June but there hasn't been a release since. -NoLogo needs removing from the line vim.opt.shell = "pwsh.exe -NoLogo"

I've also found that Lazy wont pickup new plugins until I restart lvim but that is possibly an issue I have caused.

@foolofdestiny
Copy link

foolofdestiny commented Jan 13, 2024

when u installed lunarvim did you use link provided on mainpage? and have it run through its check dependancies?
my understand is ripgrep is a/The reason cargo is listed on the main install page as a pre req

Prerequisites
Make sure you have installed the latest version of Neovim v0.9.0+.
Have git, make, pip, python, npm, node and cargo installed on your system.

the lunarvim install script should self install ripgrep via cargo

are you saying that didnt happen?

@kylo252 kylo252 changed the title Windows installation instructions are wrong Telescope dependencies are missing from windows installations Jan 17, 2024
@kylo252
Copy link
Collaborator

kylo252 commented Jan 17, 2024

These were not hard-dependencies back when we wrote the installer script.

Please create a PR to add them to this list here:

$winget_package_matrix=@{"git" = "Git.Git"; "nvim" = "Neovim.Neovim"; "make" = "GnuWin32.Make"; "node" = "OpenJS.NodeJS"; "pip" = "Python.Python.3"}
$scoop_package_matrix=@{"git" = "git"; "nvim" = "neovim-nightly"; "make" = "make"; "node" = "nodejs"; "pip" = "python3"}

@kylo252 kylo252 added packaging and removed bug Something isn't working labels Jan 17, 2024
@honeway
Copy link

honeway commented Mar 2, 2024

I didn't install make and gcc. Use VS Build Tools and cmake instead.

{ 'nvim-telescope/telescope-fzf-native.nvim', build = 'cmake -S. -Bbuild -DCMAKE_BUILD_TYPE=Release && cmake --build build --config Release && cmake --install build --prefix build' }

Copy link
Contributor

This issue is stale because it has been open for 50 days with no activity.

@github-actions github-actions bot added the stale label Apr 22, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2024
@kylo252 kylo252 reopened this May 6, 2024
@kylo252 kylo252 removed the stale label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants