Closes #69336
Closes #69377

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run pnpm test selectize.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes:
• https://selectize.dev/docs/API/selectize#removeoptiongroupid
• https://selectize.dev/docs/API/selectize#clearoptiongroups
• https://selectize.dev/docs/API/selectize#additemsvalues-silent
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

@codershiba Thank you for submitting this PR!

This is a live comment which I will keep updated.

2 packages in this PR

• node — on npm, on unpkg
  • owner-approval: @mcollina
• selectize — on npm, on unpkg

Code Reviews

This PR can be merged once it's reviewed.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 Type definition owners or DT maintainers needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 69378,
  "author": "codershiba",
  "headCommitOid": "634d3a78c6549a98c63fa88bbeadd40bf6da8fa2",
  "mergeBaseOid": "895d2be48edd77037fb8920161d109059d600002",
  "lastPushDate": "2024-04-17T10:44:15.000Z",
  "lastActivityDate": "2024-05-29T13:01:55.000Z",
  "maintainerBlessed": "Waiting for Code Reviews",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/buffer.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/dgram.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/events.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Microsoft",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "galkin",
        "parambirs",
        "eps1lon",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "peterblazejewicz",
        "addaleax",
        "victorperin",
        "ZYSzys",
        "NodeJS",
        "LinusU",
        "wafuwafu13",
        "mcollina",
        "Semigradsky"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "selectize",
      "kind": "edit",
      "files": [
        {
          "path": "types/selectize/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "adidahiya",
        "naBausch"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "mcollina",
      "date": "2024-05-29T13:01:55.000Z",
      "isMaintainer": false
    },
    {
      "type": "changereq",
      "reviewer": "sheetalkamat",
      "date": "2024-05-28T20:29:45.000Z"
    }
  ],
  "mainBotCommentID": 2060967891,
  "ciResult": "pass"
}

🔔 @microsoft @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky @adidahiya @naBausch — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@codershiba The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

Re-ping @adidahiya, @naBausch:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @codershiba.

(Ping @microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky, @adidahiya, @naBausch.)

As in the other PR, DT is at 0.12, and this package upstream is at 0.15; can you verify which versions things were added?

Need info on versions per #69378 (comment)

@codershiba One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

lgtm

@codershiba please do not mix scopes in PRs, like here, very active, critical Node package, and clearly defunct sequelize project, which is migrated and hosted on different GH repo than original one, oh, looks it now has its own DT declaration files, clearly copied from DT:
https://github.com/selectize/selectize.js/blob/master/index.d.ts
but the package.json does not publish them to NPM repo.
What should DT maintainers do?
I would say, skip sequelize (we can close issue for non-active project) and stay focused on Node

@codershiba please do not mix scopes in PRs, like here, very active, critical Node package, and clearly defunct sequelize project, which is migrated and hosted on different GH repo than original one, oh, looks it now has its own DT declaration files, clearly copied from DT: https://github.com/selectize/selectize.js/blob/master/index.d.ts but the package.json does not publish them to NPM repo. What should DT maintainers do? I would say, skip sequelize (we can close issue for non-active project) and stay focused on Node

Really sorry, the last commit was added on the wrong branch and ending up pinging the node maintainers. I apologise again and will take care of this